Skip to content

fix(streams-bootstrap): set correct type for secretFilesRefs #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
disrupted merged 2 commits into from
Oct 8, 2025
Merged

fix(streams-bootstrap): set correct type for secretFilesRefs #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ad7f5e
test(streams-bootstrap): create failing test case
disrupted Oct 8, 2025
c16354e
fix(schema): set correct type for secretFilesRefs
disrupted Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/docs/schema/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2211,7 +2211,7 @@
"anyOf": [
{
"items": {
"type": "string"
"type": "object"
},
"type": "array"
},
Expand Down Expand Up @@ -3398,7 +3398,7 @@
"anyOf": [
{
"items": {
"type": "string"
"type": "object"
},
"type": "array"
},
Expand Down Expand Up @@ -4019,7 +4019,7 @@
"anyOf": [
{
"items": {
"type": "string"
"type": "object"
},
"type": "array"
},
Expand Down
4 changes: 2 additions & 2 deletions docs/docs/schema/pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1866,7 +1866,7 @@
"anyOf": [
{
"items": {
"type": "string"
"type": "object"
},
"type": "array"
},
Expand Down Expand Up @@ -3053,7 +3053,7 @@
"anyOf": [
{
"items": {
"type": "string"
"type": "object"
},
"type": "array"
},
Expand Down
2 changes: 1 addition & 1 deletion kpops/components/streams_bootstrap/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class StreamsBootstrapValues(SerializeAsOptionalModel, HelmAppValues):
env: SerializeAsOptional[dict[str, str]] = {}
secrets: SerializeAsOptional[dict[str, str]] = {}
secret_refs: SerializeAsOptional[dict[str, Any]] = {}
secret_files_refs: SerializeAsOptional[list[str]] = []
secret_files_refs: SerializeAsOptional[list[dict[str, Any]]] = []
files: SerializeAsOptional[dict[str, Any]] = {}
java_options: JavaOptions | None = None
pod_annotations: SerializeAsOptional[dict[str, str]] = {}
Expand Down
23 changes: 23 additions & 0 deletions tests/components/streams_bootstrap/test_streams_bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,3 +289,26 @@ def test_node_affinity(self):
}
],
}

def test_secret_files_refs(self):
model = StreamsBootstrap.model_validate(
{
"name": "example-name",
"namespace": "test-namespace",
"values": {
"image": "streamsBootstrap",
"kafka": {
"bootstrapServers": "localhost:9092",
},
"secretFilesRefs": [
{
"name": "foo",
"volume": "bar",
"mountPath": "/some/path/",
"readOnly": True,
}
],
},
},
)
assert model.values.secret_files_refs
Loading