remove Workaround messages to stop build.sh breaking#57
Open
rcooke-warwick wants to merge 1 commit intomasterfrom
Open
remove Workaround messages to stop build.sh breaking#57rcooke-warwick wants to merge 1 commit intomasterfrom
rcooke-warwick wants to merge 1 commit intomasterfrom
Conversation
Change-type: patch Signed-off-by: Ryan Cooke <ryan@balena.io>
alexgg
requested changes
Dec 26, 2023
| fi | ||
|
|
||
| if [[ "$device" == asus-tinker* ]] ; then | ||
| echo Workaround tinkerboard |
Contributor
There was a problem hiding this comment.
Probably better to leave the message but redirect it to stderr:
echo "Workaround tinkerboard" >&2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a devicetype that invokes the
workaround.shfile, theecho Workaround <device>messages break the build script - this is because in the build script, the output offetch_headersis expected to be the path to the temporary folder containing the headers ONLY - and the extra workaround messages pollute this string.Change-type: patch