Add modelInputs width, height, num_inference_steps, guidance_scale#6
Open
gadicc wants to merge 1 commit intobananaml:mainfrom
Open
Add modelInputs width, height, num_inference_steps, guidance_scale#6gadicc wants to merge 1 commit intobananaml:mainfrom
gadicc wants to merge 1 commit intobananaml:mainfrom
Conversation
|
Argument positioning is wrong, Width changes the height. Needs a re-order or keyword arguments. At least that's what happened when I tested locally |
Author
|
Ughhh thanks so much for reporting! 😅 Have fixed this now. Fixed the order AND switched to keyword arguments 😅 😅 |
|
@gadicc are there plans to merge this / are you using this in |
Author
|
@0xspeedrunner, here's the full source for what we're using prod for kiri.art :) https://github.com/gadicc/banana-sd-base It's not as beginner friendly as this repo but feel free to open any issues there if anything is unclear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
Passes on some common model inputs (
width,height,num_inference_steps,guidance_scale).Why?
They're useful :)
How did you test it?
Have been running locally in https://github.com/gadicc/stable-diffusion-react-nextjs-mui-pwa for a few days, and deployed.
Comments
init_imageandstrength(iirc) stuff next when I get to that part of my app.No urgency from my side, already running this deployed, but figured it would be useful for others.