chore(deps): update dependency nodemailer to v8.0.5 [security]#44
Open
renovate[bot] wants to merge 1 commit intomainfrom
Open
chore(deps): update dependency nodemailer to v8.0.5 [security]#44renovate[bot] wants to merge 1 commit intomainfrom
renovate[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
8.0.4→8.0.5GitHub Vulnerability Alerts
GHSA-vvjj-xcjg-gr5g
Summary
Nodemailer versions up to and including 8.0.4 are vulnerable to SMTP command injection via CRLF sequences in the transport
nameconfiguration option. Thenamevalue is used directly in the EHLO/HELO SMTP command without any sanitization for carriage return and line feed characters (\r\n). An attacker who can influence this option can inject arbitrary SMTP commands, enabling unauthorized email sending, email spoofing, and phishing attacks.Details
The vulnerability exists in
lib/smtp-connection/index.js. When establishing an SMTP connection, thenameoption is concatenated directly into the EHLO command:The
_sendCommandmethod writes the string directly to the socket followed by\r\n(line 1082):If the
nameoption contains\r\nsequences, each injected line is interpreted by the SMTP server as a separate command. Unlike theenvelope.fromandenvelope.tofields which are validated for\r\n(line 1107-1119), and unlikeenvelope.sizewhich was recently fixed (GHSA-c7w3-x93f-qmm8) by casting to a number, thenameparameter receives no CRLF sanitization whatsoever.This is distinct from the previously reported GHSA-c7w3-x93f-qmm8 (envelope.size injection) as it affects a different parameter (
namevssize), uses a different injection point (EHLO command vs MAIL FROM command), and occurs at connection initialization rather than during message sending.The
nameoption is also used in HELO (line 1384) and LHLO (line 1333) commands with the same lack of sanitization.PoC
Running this PoC shows the SMTP server receives the injected MAIL FROM, RCPT TO, DATA, and phishing email content as separate SMTP commands before the legitimate email is sent.
Impact
Who is affected: Applications that allow users or external input to configure the
nameSMTP transport option. This includes:What can an attacker do:
The injection occurs at the EHLO stage (before authentication in most SMTP flows), making it particularly dangerous as the injected commands may be processed with the server's trust context.
Recommended fix: Sanitize the
nameoption by stripping or rejecting CRLF sequences, similar to howenvelope.fromandenvelope.toare already validated on lines 1107-1119 oflib/smtp-connection/index.js. For example:Release Notes
nodemailer/nodemailer (nodemailer)
v8.0.5Compare Source
Bug Fixes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.