Skip to content

Use event delegation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samselikoff wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use event delegation #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions addon/components/pushy-left.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default Ember.Component.extend({
pushyActiveClass = "pushy-active", //css class to toggle site overlay
containerClass = "container-push", //container open class
pushClass = "push-push", //css class to add pushy capability
menuBtn = $('.menu-btn, .pushy a'), //css classes to toggle the menu
menuBtnClasses = '.menu-btn, .pushy a', //css classes to toggle the menu
menuSpeed = 200, //jQuery fallback menu speed
menuWidth = pushy.width() + "px"; //jQuery fallback menu width

Expand Down Expand Up @@ -70,7 +70,7 @@ export default Ember.Component.extend({

if(cssTransforms3d){
//toggle menu
menuBtn.click(function() {
$('body').on('click', menuBtnClasses, function() {
togglePushy();
});
//close menu when clicking site overlay
Expand All @@ -86,7 +86,7 @@ export default Ember.Component.extend({
var state = true;

//toggle menu
menuBtn.click(function() {
$('body').on('click', menuBtnClasses, function() {
if (state) {
openPushyFallback();
state = false;
Expand Down