fix: prevent sybil bypass via delete then re claim and fix status code mismatch#25
Open
Sertug17 wants to merge 1 commit into
Open
fix: prevent sybil bypass via delete then re claim and fix status code mismatch#25Sertug17 wants to merge 1 commit into
Sertug17 wants to merge 1 commit into
Conversation
…e mismatch Bug 1 (Critical): delete-airdrop removes user record but does not track the verification token. A user can claim multiple times with different wallets using the same verified social account. Fixed by adding a DeletedToken model that tracks tokens from deleted claims, checked on re-verification. Bug 2 (Minor): Frontend checks HTTP 400 but backend returns HTTP 412 for traits-not-satisfied. Fixed frontend to match backend status code. Closes base#24
|
@Sertug17 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Would appreciate a review on this when either of you gets a chance. Fixes a sybil bypass in the claim flow (delete + re-claim reuses the same verification token) and corrects a status code mismatch between frontend and backend for the traits-not-satisfied path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.