Skip to content

Conversation

@meyer9
Copy link
Collaborator

@meyer9 meyer9 commented Oct 28, 2025

Description

Fixes fetching metadata and test runs on GHA. Previously, we used a relative path, so requesting output/metadata.json would resolve to https://base.github.io/benchmark/output/metadata.json when requested from https://base.github.io/benchmark.

The previous change added a leading / to the beginning of the path, so it was not resolving the relative path correctly. Now, we ensure the base url has a trailing / and remove the leading / from request URLs so the static site is portable to any path.

Testing

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 28, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@meyer9 meyer9 requested a review from tobidae-cb October 28, 2025 18:53
@meyer9 meyer9 enabled auto-merge (squash) October 28, 2025 18:53
@meyer9 meyer9 merged commit fa34c05 into main Oct 28, 2025
10 checks passed
@meyer9 meyer9 deleted the meyer9/fix-github-actions-relative-path branch October 28, 2025 19:09
tobidae-cb pushed a commit that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants