Skip to content

fix: no trailing slash if not set #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
meyer9 merged 1 commit into from
Oct 28, 2025
Merged

fix: no trailing slash if not set #119

meyer9 merged 1 commit into from
Oct 28, 2025

Conversation

@meyer9
Copy link
Collaborator

@meyer9 meyer9 commented Oct 28, 2025

Description

There should be no trailing slash if baseUrl is empty.

Testing

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 28, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@meyer9 meyer9 enabled auto-merge (squash) October 28, 2025 22:19
@meyer9 meyer9 merged commit 31a0f8f into main Oct 28, 2025
10 checks passed
@meyer9 meyer9 deleted the meyer9/trailing-slash branch October 28, 2025 22:27
tobidae-cb pushed a commit that referenced this pull request Dec 5, 2025
@meyer9 @tobidae-cb
fix: no trailing slash if not set (#119)
00c2f6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leopoldjoy leopoldjoy leopoldjoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meyer9 @cb-heimdall @leopoldjoy