Skip to content

feat: hide machine info if unavailable #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meyer9 merged 1 commit into from
Oct 31, 2025
Merged

feat: hide machine info if unavailable #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions report/src/components/MachineInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,7 @@ const MachineInfo = ({ machineInfo }: MachineInfoProps) => {
!machineInfo.region &&
!machineInfo.fileSystem)
) {
return (
<div className="bg-slate-50 rounded-lg p-4 border border-slate-200">
<h3 className="text-sm font-semibold text-slate-700 mb-2">
Machine Information
</h3>
<p className="text-sm text-slate-500">
Machine information not available for this benchmark run.
</p>
</div>
);
return null;
}

const providerUrl =
Expand Down
16 changes: 2 additions & 14 deletions report/src/components/RunList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,21 +340,9 @@ const RunList = ({
{isExpanded && (
<div className="mt-4">
{/* Machine Information Section */}
{section.runs.length > 0 && (
{section.runs[0]?.machineInfo && (
<div className="mb-6">
{section.runs[0].machineInfo ? (
<MachineInfo machineInfo={section.runs[0].machineInfo} />
) : (
<div className="bg-slate-50 rounded-lg p-4 border border-slate-200">
<h3 className="text-sm font-semibold text-slate-700 mb-2">
Machine Information
</h3>
<p className="text-sm text-slate-500">
Machine information not available for this benchmark
run.
</p>
</div>
)}
<MachineInfo machineInfo={section.runs[0]?.machineInfo} />
</div>
)}
<table className="min-w-full">
Expand Down
Loading