refactor: consolidate AccountConfiguration, restructure account hierarchy, tidy docs#24
Merged
Merged
Conversation
…rchy, tidy docs - Merge IAccountConfiguration into AccountConfiguration (drop the separate interface). - Rename SCOPE_CHANGE_ACTORS -> SCOPE_CONFIG to match the EIP-8130 spec. - Rename BackwardCompatibleERC4337Account -> Default4337Account and make ERC-4337 an opt-in building block; nothing deployed by default depends on it. - UpgradeableAccount now extends DefaultAccount (no 4337 surface by default). Upgrades are authorized only via the CONFIG-signed upgradeBySignature path; a one-shot flag guards _authorizeUpgrade so executeBatch/self-calls cannot smuggle an upgrade. - Pin solc 0.8.30 for reproducible addresses. - Tidy NatSpec across accounts and example policies (remove negative/hypothetical framing). - Update unit tests, scripts, and README to match.
2 tasks
…ible4337Account Reframe the ERC-4337 account as an explicit opt-in example rather than a core building block: relocate it under src/accounts/example/ and rename the contract to BackwardsCompatible4337Account. Update all references (UpgradeableAccount/UpgradeableProxy docs, README, deploy script) and move the test suite to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IAccountConfigurationintoAccountConfigurationand drop the separate interface.SCOPE_CHANGE_ACTORS→SCOPE_CONFIGto match the EIP-8130 spec.BackwardCompatibleERC4337Account→Default4337Accountand make ERC-4337 an opt-in building block — nothing deployed by default depends on it.UpgradeableAccountnow extendsDefaultAccount(no 4337 surface by default). Upgrades are authorized only via the CONFIG-signedupgradeBySignaturepath; a one-shot flag guards_authorizeUpgradeso anexecuteBatchself-call can't smuggle an upgrade through a SENDER-scoped key.solc = 0.8.30for reproducible addresses.Test plan
forge fmt --checkforge build --sizesforge test— 207 passed, 0 failed