refactor(net): use provided RNG for random value generation #5
+8
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace direct calls to B256::random() and B512::random() with rng.gen() to use the provided random number generator consistently throughout the networking crates. This resolves TODO(rand) comments and ensures better testability and determinism when using seeded RNGs. Changes: - crates/net/ecies/src/algorithm.rs: Use rng.gen() for nonce generation in new_client() and new_server() methods - crates/net/discv4/src/test_utils.rs: Use rng.gen() for B512 ID generation in rng_record(), rng_ipv6_record(), and rng_ipv4_record() functions - testing/testing-utils/src/generators.rs: Use rng.gen() for B256 generation in random_contract_account_range() and random_log() functions This improves code consistency and makes testing more reliable by respecting the RNG parameter provided to these functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves multiple TODO(rand) comments by replacing direct calls to
B256::random()andB512::random()withrng.gen()to consistently use the provided random number generator throughout the networking crates.Motivation
The existing code had several TODO comments indicating that random value generation should use the provided RNG parameter instead of direct
::random()calls. Using the provided RNG ensures:Changes
crates/net/ecies/src/algorithm.rsnew_client()to userng.gen()instead ofB256::random()new_server()to userng.gen()instead ofB256::random()crates/net/discv4/src/test_utils.rsrng_record()to userng.gen()rng_ipv6_record()to userng.gen()rng_ipv4_record()to userng.gen()rng_message()to userng.gen()testing/testing-utils/src/generators.rsrandom_contract_account_range()to userng.gen()random_log()to userng.gen()Testing
The changes maintain existing behavior while improving code consistency. All modified functions already accept an RNG parameter, so this change simply ensures the provided RNG is used throughout.
Type of Change