docs: add --broadcast to forge create deploy commands#141
Open
memosr wants to merge 1 commit into
Open
Conversation
Foundry 1.0+ requires --broadcast for forge create to actually deploy; without it the command dry-runs and --verify never executes. Verified empirically with forge 1.7.1 + anvil (prints the 'add --broadcast' warning).
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testnet and mainnet forge create commands in deploy-contracts.md are missing --broadcast. In Foundry 1.0+, forge create without --broadcast only dry-runs (prints: 'To broadcast this transaction, add --broadcast to the previous command'), so the contract never deploys and --verify never runs.
Verified empirically with forge 1.7.1 + anvil. Added --broadcast to both real deploy commands; left the partial --etherscan-api-key example (not a full deploy command) untouched.
Docs-only.