feat: publish to audit kafka async #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlawt
commented
Nov 7, 2025
crates/ingress-rpc/src/service.rs
Outdated
| }; | ||
| if let Err(e) = self.audit_publisher.publish(audit_event).await { | ||
| warn!(message = "Failed to publish audit event", bundle_id = %accepted_bundle.uuid(), error = %e); | ||
| let (audit_tx, audit_rx) = mpsc::unbounded_channel::<BundleEvent>(); |
Contributor
Author
There was a problem hiding this comment.
we might want a cap on this? (could do in a follow up)
Collaborator
There was a problem hiding this comment.
You'll probably want to initialize the queue in main, then have the ingress-service just take the queue.
I think this code will have a race condition in that if the queue is dropped before this method it'll never be processed by the spawned task.
If you setup the queue in main, connect it to the publisher there then pass it as an arg to this struct it should work
danyalprout
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us not block on waiting for a response from the Audit queue
Also made the Bundle Status text black because the grey color was too similar to the white box, which makes it hard to read lol
Tested locally e2e again, and everything still works.