Add LWW-Element-Set with Add-Wins semantic for equal timestamp#102
Open
Add LWW-Element-Set with Add-Wins semantic for equal timestamp#102
Conversation
Closed
Contributor
|
Two dialyzer errors: |
I'll update Roshi's docs to clarify my (perhaps eccentric) use of the term GC, and explicitly mention the possibility of doomstones (hehe). Thanks for writing! |
Typos and clarifications
…cross datatypes for small perf gain
Bring develop up-to-date with develop-2.2
Hex package
Gsets for bet
typo
Fix typo in README.md
Also move to `dict` from `orddict` for better performance in larger sets. Retain `orddict` for EQC for ease of reading.
083d89b to
ea3a425
Compare
Contributor
Author
|
Re-based on develop. Brought up to date.
Just needs a friendly lil' +1 from someone out there… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An LWW-Element-Set similar to Roshi/The Shapiro Tech Report. When an add and remove on the same element have the same timestamp, the add wins. Why? Makes sense to me that you only remove a element you've seen in the set, and if you remove
aat time1then theayou saw must have been added at some time<1. Therefore an add ofaat1is not the sameathe remove wants to remove.If there is a need for a remove wins version, we could tweak this impl to provide either based on some setup param, I guess.
Despite what the Roshi docs say, there is no GC, and there are in fact tombstones. Once an element is added it will always take up space in the datastructure.
Also, "doomstones" allowed (you can remove
{a, 100000}whenais not present, and no add ofaless than100000will work.)