Merged
Conversation
Unicode in input was being handled correctly by the riak_shell lexer/parser (and by the SQL one) but not by the cmd pretty printer This is used in writing the history and the logs and it was borking on unicode - in particular smart quotes inserted into SQL on pasting from some editors. The regular expression clean up and output munging is now unicode friendly. riak_shell doesn't log errored commands so it is hard to regression test for this.
Contributor
|
Thanks @gordonguthrie! Settings---
minimum_reviewers: 2
build_steps:
- make clean
- make deps
- make compile
- make test
- make xref
- make dialyzer
merge: true
org_mode: true
timeout: 1790 |
Contributor
There seems to be an issue with build step **make_test** ! ☁️✅ MERGE
✅ MAKE_CLEAN
✅ MAKE_DEPS
✅ MAKE_COMPILE
⛔ MAKE_TEST
✅ MAKE_XREF
✅ MAKE_DIALYZER
⬜ 0 of 2 Code reviews from organization basho |
Contributor
Author
|
Associated with this |
Contributor
|
+1 |
1 similar comment
Contributor
|
+1 |
hazen
reviewed
Dec 12, 2016
| pad(X) when is_integer(X) -> | ||
| io_lib:format("~2.10.0B", [X]). | ||
|
|
||
| -ifdef(TEST). |
|
Looks like we actually ignored the output of Thumbs @gordonguthrie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unicode in input was being handled correctly by the riak_shell
lexer/parser (and by the SQL one) but not by the cmd pretty printer
This is used in writing the history and the logs and it was borking
on unicode - in particular smart quotes inserted into SQL on pasting
from some editors.
The regular expression clean up and output munging is now unicode
friendly.
riak_shell doesn't log errored commands so it is hard to regression
test for this.