Create verify_repl_deleteonfail.erl#1381
Open
martinsumner wants to merge 1 commit intodevelop-3.0from
Open
Conversation
ThomasArts
reviewed
Sep 1, 2023
| %% | ||
| %% ------------------------------------------------------------------- | ||
| %% @doc When replicating deletes, if a node is down in the cluster, clusters | ||
| %% will get out of sync, unless the deletion of tombstones is deferred when |
There was a problem hiding this comment.
Suggested change
| %% will get out of sync, unless the deletion of tombstones is deferred when | |
| %% will get out of sync, unless the deletion of tombstones is deferred as long as |
ThomasArts
reviewed
Sep 1, 2023
| hd(Nodes), <<"B1">>, lists:seq(1, ?NUM_KEYS_PERNODE * length(Nodes))), | ||
| lager:info("Delete attempts completed"), | ||
| wait_for_queues_to_drain(Nodes -- [FiddlingNode], cluster_b), | ||
|
|
There was a problem hiding this comment.
Strictly spoken, from the function name "wait_for_queues_to_drain", I cannot confirm here that the tombstones are deferred... Some observation of that fact after a certain time would make this test indeed show the point.
Most likely just a matter of some additional explanation on what is happening here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basho/riak_kv#1870