Open
Conversation
Previously an issue upgrading downgrading eleveldb was undetected by riak_test.
Confirm size does shrink non-trivially with compression enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic upgrade was too basic:
It didn't test different compression setting so missed issues such as - basho/eleveldb#273;
It didn't detect if compression wasn't working so missed issues such as - basho/eleveldb#275;
It tested too small a data set, and so could mask issues as only uncompressed parts of the file structure would be tested;
It didn't test updates between the upgrade and the downgrade.
This test should now be better at upgrade issues related to backend changes.