Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
857dbcf
tests: test beam search results
anmorgunov Oct 2, 2025
111dd9f
dev: resolve lint issues
anmorgunov Oct 3, 2025
6dd518a
dev: develop batched beam
anmorgunov Oct 3, 2025
312743f
dev: seems to be working somewhat
anmorgunov Oct 3, 2025
2dc2a4a
dev: now def seems to work
anmorgunov Oct 3, 2025
aab65e3
dev: harder beam script
anmorgunov Oct 3, 2025
d092a5d
dev: pad the noSM inputs
anmorgunov Oct 3, 2025
ca521bf
tests: add pharma based test
anmorgunov Oct 3, 2025
48ffdae
dev: upd run script
anmorgunov Oct 3, 2025
cf81372
dev: patch the colection of non-batched
anmorgunov Oct 3, 2025
081469a
dev: expose both copies vec and nonvec
anmorgunov Oct 3, 2025
6fd7624
dev: add vec nonvec comparison test
anmorgunov Oct 3, 2025
1cd492e
dev: try s4.5
anmorgunov Oct 3, 2025
7744962
dev: tr2
anmorgunov Oct 3, 2025
b99fb42
tests: more vec non vec tests
anmorgunov Oct 3, 2025
cca3411
patch test
anmorgunov Oct 3, 2025
9da296d
patch more tests
anmorgunov Oct 3, 2025
e26772a
dev: switch to vectorized
anmorgunov Oct 3, 2025
f243ff6
dev: parity achieved LMAO
anmorgunov Oct 3, 2025
2d64307
dev: upd script
anmorgunov Oct 3, 2025
34e3d5d
dev: higher beam for last test
anmorgunov Oct 3, 2025
f1eefea
dev: remove the slow one
anmorgunov Oct 3, 2025
aeee38d
dev: add b50 test
anmorgunov Oct 3, 2025
4024584
dev: make sure the reusable tensors are re-initialized
anmorgunov Oct 3, 2025
d991eb2
dev: make sure the reusable tensors are re-initialized
anmorgunov Oct 3, 2025
bf47255
dev: try v2
anmorgunov Oct 3, 2025
bf4983b
dev: drop old batch and clean tests
anmorgunov Oct 3, 2025
9b99b76
dev: don't even import it
anmorgunov Oct 3, 2025
9a6eedc
dev: yet another fix and dont run CI on pushes to non-master
anmorgunov Oct 3, 2025
6cd8ba4
dev: fix indentation for last test
anmorgunov Oct 3, 2025
9b30992
dev: that's it folks, sonnet 4.5
anmorgunov Oct 3, 2025
1fbbaeb
dev: infer dtypes for fp16
anmorgunov Oct 3, 2025
d1d6662
feat: well one eternity later, is it working
anmorgunov Oct 3, 2025
6461c98
clean up
anmorgunov Oct 3, 2025
14afc08
rename for clarity
anmorgunov Oct 3, 2025
04622e7
respond to rabbit's comments
anmorgunov Oct 3, 2025
4e65b74
remove unused code
anmorgunov Oct 3, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 49 additions & 41 deletions .github/workflows/linting.yml
Original file line number Diff line number Diff line change
@@ -1,49 +1,57 @@
name: Linting

on: [push, pull_request]
on:
push:
branches:
- main
- master
pull_request:
branches:
- main
- master

jobs:
lint:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Python 3.11
uses: actions/setup-python@v4
with:
python-version: '3.11'

- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
echo "$HOME/.cargo/bin" >> $GITHUB_PATH

- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.cache/uv
~/.uv
.venv
key: ${{ runner.os }}-uv-${{ hashFiles('pyproject.toml') }}
restore-keys: |
${{ runner.os }}-uv-

- name: Create and activate virtual environment
run: |
uv venv
echo "$PWD/.venv/bin" >> $GITHUB_PATH

- name: Install dependencies
run: uv sync

- name: Run ruff (linter)
run: ruff check

- name: Run ruff (formatter)
run: ruff format --check

- name: Run mypy
run: mypy .
- name: Checkout
uses: actions/checkout@v4

- name: Set up Python 3.11
uses: actions/setup-python@v4
with:
python-version: "3.11"
Comment on lines +21 to +24

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Update deprecated GitHub Action version.

Same as testing.yml: actions/setup-python@v4 is outdated. Update to v5 for better Python 3.11+ support.

Apply this diff:

-      - name: Set up Python 3.11
-        uses: actions/setup-python@v4
-        with:
-          python-version: "3.11"
+      - name: Set up Python 3.11
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.11"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Set up Python 3.11
uses: actions/setup-python@v4
with:
python-version: "3.11"
- name: Set up Python 3.11
uses: actions/setup-python@v5
with:
python-version: "3.11"
🧰 Tools
🪛 actionlint (1.7.7)

22-22: the runner of "actions/setup-python@v4" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents
.github/workflows/linting.yml lines 21-24: the workflow uses the deprecated
actions/setup-python@v4; update the action reference to actions/setup-python@v5
to ensure current support for Python 3.11+ and replace the version string in the
uses field accordingly.


- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
echo "$HOME/.cargo/bin" >> $GITHUB_PATH

- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.cache/uv
~/.uv
.venv
key: ${{ runner.os }}-uv-${{ hashFiles('pyproject.toml') }}
restore-keys: |
${{ runner.os }}-uv-

- name: Create and activate virtual environment
run: |
uv venv
echo "$PWD/.venv/bin" >> $GITHUB_PATH

- name: Install dependencies
run: uv sync

- name: Run ruff (linter)
run: ruff check

- name: Run ruff (formatter)
run: ruff format --check

- name: Run mypy
run: mypy .
79 changes: 44 additions & 35 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
@@ -1,42 +1,51 @@
name: Tests

on: [pull_request]
on:
push:
branches:
- main
- master
pull_request:
branches:
- main
- master

jobs:
test:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Set up Python 3.13
uses: actions/setup-python@v4
with:
python-version: '3.13'

- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
echo "$HOME/.cargo/bin" >> $GITHUB_PATH

- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.cache/uv
~/.uv
.venv
key: ${{ runner.os }}-uv-${{ hashFiles('pyproject.toml') }}
restore-keys: |
${{ runner.os }}-uv-

- name: Create and activate virtual environment
run: |
uv venv
echo "$PWD/.venv/bin" >> $GITHUB_PATH

- name: Install dependencies
run: uv sync

- name: Run tests
run: pytest -v
- name: Checkout
uses: actions/checkout@v4

- name: Set up Python 3.11
uses: actions/setup-python@v5
with:
python-version: "3.11"

- name: Install uv
run: |
curl -LsSf https://astral.sh/uv/install.sh | sh
echo "$HOME/.cargo/bin" >> $GITHUB_PATH

- name: Cache dependencies
uses: actions/cache@v4
with:
path: |
~/.cache/uv
~/.uv
.venv
key: ${{ runner.os }}-uv-${{ hashFiles('pyproject.toml') }}
restore-keys: |
${{ runner.os }}-uv-

- name: Create and activate virtual environment
run: |
uv venv
echo "$PWD/.venv/bin" >> $GITHUB_PATH

- name: Install dependencies
run: uv sync

- name: Run tests
run: pytest -v
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,5 @@ debug*
slurm*.out
submit*.sh
qual.sh

collectors/
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ repos:
entry: ruff check --fix
language: python
types: [python]

- id: ruff-format
name: ruff (formatter)
entry: ruff format
Expand All @@ -18,8 +18,8 @@ repos:

- id: mypy
name: mypy
entry: mypy
entry: uv run mypy
language: system
types: [python]
exclude: ^(tests/)
args: ["--config-file=pyproject.toml"]
args: ["--config-file=pyproject.toml"]
Loading
Loading