Make user profile page (without ranking chart) #849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrantel
force-pushed
the
seren/user-profile
branch
from
3ab9f66 to
0469810
Compare
lowtorola
reviewed
Nov 23, 2024
frontend2/src/views/UserProfile.tsx
Outdated
Comment on lines
9
to
11
| const isNilOrEmptyStr = (str: string | undefined | null): boolean => { | ||
| return isNil(str) || str === ""; | ||
| }; |
Contributor
There was a problem hiding this comment.
nit: move to helpers.ts so we can refactor all uses of this sort of thing
lowtorola
reviewed
Nov 23, 2024
lowtorola
reviewed
Nov 23, 2024
| ); | ||
| }; | ||
|
|
||
| const UserNotFound: React.FC = () => { |
lowtorola
reviewed
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the path is
/user/<userid>for these user pagesCLOSES #787 closes #845