Create React App -> Vite #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@acrantel this almost works it just needs its upgraded eslint to have the rules that the old eslint had i think? was there a systematic way we determined those old rules or some way I could know what exactly we want to have throw an error when running lint? |
eslint almost working need rules
ignore magic 0 1 -1 tmp checkpoint commit fixed all lint errors rebased
lowtorola
force-pushed
the
cra-to-vite
branch
from
bf19c58 to
20c5e98
Compare
Contributor
Author
|
@acrantel this is done 🚀 |
acrantel
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #842 🚀
Side note: it should be really easy to do relative imports now! I may look at that when i get a chance!