Make runtime titles not have double versions#1307
Merged
kolunmi merged 3 commits intobazaar-org:mainfrom Mar 22, 2026
Merged
Conversation
For some reason, some GNOME runtime titles included a version number like "49" at the end, while the actual version was something different like 50. This caused the old algorithm to combine both values and return "49 50". To fix this, we now remove the version number from the title entirely and append the correct version value.
AlexanderVanhee
added
UX
Collaborator
|
It might be inefficient to compile that regex every time we process a new entry, perhaps we can wrap this in a |
Collaborator
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, some GNOME runtime titles included a version number like "49" at the end, while the actual version was something different like 50. This caused the old algorithm to combine both values and return "49 50". To fix this, we now remove the version number from the title entirely and append the correct version value.