Skip to content

fix: Bump minimum protobuf version to 31.0 to fix dropped 3.8 support #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ahajha wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix: Bump minimum protobuf version to 31.0 to fix dropped 3.8 support #3446

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1523310
Bump minimum protobuf version to 31.0-rc1
Ahajha Dec 7, 2025
bf05eb2
use non-rc
Ahajha Dec 7, 2025
b0c49b6
Merge branch 'main' into ahajha/bump-protobuf
aignas Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ bazel_dep(name = "platforms", version = "0.0.11")

# Those are loaded only when using py_proto_library
# Use py_proto_library directly from protobuf repository
bazel_dep(name = "protobuf", version = "29.0-rc2", repo_name = "com_google_protobuf")
bazel_dep(name = "protobuf", version = "31.0-rc1", repo_name = "com_google_protobuf")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it would be helpful to add a comment explaining why this specific release candidate version of protobuf is being used. This provides context for future developers who might wonder about this version pin. Refactoring to a multi-line bazel_dep call would be a clean way to include this information.

bazel_dep(
    name = "protobuf",
    # Pinned to 31.0-rc1 to fix an issue with dropped Python 3.8 support.
    # See: https://github.com/jvolkman/rules_pycross/issues/209
    version = "31.0-rc1",
    repo_name = "com_google_protobuf",
)


rules_python_config = use_extension("//python/extensions:config.bzl", "config")
use_repo(
Expand Down