Fix notify_command.go to pass argsallowing --test_sharding_strategy=disabled with --#816
Open
Aghassi wants to merge 3 commits intobazelbuild:mainfrom
Open
Fix notify_command.go to pass argsallowing --test_sharding_strategy=disabled with --#816Aghassi wants to merge 3 commits intobazelbuild:mainfrom
Aghassi wants to merge 3 commits intobazelbuild:mainfrom
Conversation
Fixes a bug introduced by bazelbuild#744 where on bazel run with sharding enabled the process would fail to launch. this also requires the user to use the `--` attribute before passing the flag so it gets sorted into args
add new argument to test
Include a focused Start() test for args passed after double-dash, and update existing expectations to reflect the extra SetArguments call.
Contributor
Author
|
@achew22 Let me know if the test is what you envisioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#775
Reopens the above commit