Skip to content

Make libclang attr as optional in the rust_bindgen_toolchain #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaibhav-1207 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −7
Open

Make libclang attr as optional in the rust_bindgen_toolchain #3788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions extensions/bindgen/private/bindgen.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,22 +216,24 @@ def _rust_bindgen_impl(ctx):
toolchain = ctx.toolchains[Label("//:toolchain_type")]
bindgen_bin = toolchain.bindgen
clang_bin = toolchain.clang
libclang = toolchain.libclang
libstdcxx = toolchain.libstdcxx
libclang = getattr(toolchain, "libclang", None)
libstdcxx = getattr(toolchain, "libstdcxx", None)

output = ctx.outputs.out

cc_toolchain, feature_configuration = find_cc_toolchain(ctx = ctx)

tools = depset(([clang_bin] if clang_bin else []), transitive = [cc_toolchain.all_files])

# libclang should only have 1 output file
libclang_dir = _get_libs_for_static_executable(libclang).to_list()[0].dirname

env = {
"LIBCLANG_PATH": libclang_dir,
"RUST_BACKTRACE": "1",
}

if libclang:
# libclang should only have 1 output file
libclang_dir = _get_libs_for_static_executable(libclang).to_list()[0].dirname
env["LIBCLANG_PATH"] = libclang_dir

if clang_bin:
env["CLANG_PATH"] = clang_bin.path

Expand Down Expand Up @@ -378,8 +380,9 @@ def _rust_bindgen_impl(ctx):
[header],
transitive = [
cc_lib[CcInfo].compilation_context.headers,
_get_libs_for_static_executable(libclang),
] + ([
_get_libs_for_static_executable(libclang),
] if libclang else []) + ([
_get_libs_for_static_executable(libstdcxx),
] if libstdcxx else []),
),
Expand Down Expand Up @@ -529,6 +532,7 @@ For additional information, see the [Bazel toolchains documentation](https://doc
cfg = "exec",
providers = [CcInfo],
allow_files = True,
mandatory = False,
),
"libstdcxx": attr.label(
doc = "A cc_library that satisfies libclang's libstdc++ dependency. This is used to make the execution of clang hermetic. If None, system libraries will be used instead.",
Expand Down