WS-222: [CANONICAL] - Delete dead/unused ATI code in Simorgh #13526

alex-magana · 2025-12-09T12:14:04Z

Resolves JIRA: WS-222

Summary

Phase out the legacy ATI/Piano code from the Simorgh codebase following successful migration
of page and component tracking to Reverb.

Code changes

Update Cypress e2e tests for Home Page, Live Radio, Most Read Page, OnDemand
Audio, OnDemand TV and Topic Page to revert utility of useReverb config for the Express app.
Update atiAnalytics component event tracking assertions for the Express app.

cypress/e2e/specialFeatures/atiAnalytics/assertions/articleLiteSiteLink.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/billboard.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/featuresAnalysis.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/latestMedia.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/liveMedia.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/messageBanner.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/mostRead.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/navigation.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/podcastLinks.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/podcastPromo.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/portraitVideoCarousel.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/portraitVideoModal.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/radioSchedule.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/recentAudioEpisodes.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/recommendations.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/relatedContent.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/relatedTopics.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/scrollablePromo.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/share.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/socialEmbed.js
cypress/e2e/specialFeatures/atiAnalytics/assertions/topStories.js

Revert changes in NOTICKET - Temporarily comment out atuserId e2es #13396 via
cypress/e2e/specialFeatures/atiAnalytics/assertions/index.js
Reduce bundle size MIN_SIZE and MAX_SIZE.
Update Cypress e2e tests for Article Page, Languages Pages, Live Page,
Media Asset Page, Photo Gallery Page and Story Page to revert utility of useReverb config for the Next.js app.

ws-nextjs-app/cypress/e2e/articlePage/index.cy.ts
ws-nextjs-app/cypress/e2e/languagesPage/index.cy.ts
ws-nextjs-app/cypress/e2e/livePage/index.cy.ts
ws-nextjs-app/cypress/e2e/mediaAssetPage/index.cy.ts
ws-nextjs-app/cypress/e2e/photoGalleryPage/index.cy.ts
ws-nextjs-app/cypress/e2e/storyPage/index.cy.ts

Update atiAnalytics component event tracking assertions for the Next.js app.

ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/articleLiteSiteLink.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/featuresAnalysis.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/latestMedia.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/mostRead.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/mostRead.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/podcastPromo.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/recommendations.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/recommendations.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/relatedTopics.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/scrollablePromo.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/socialEmbed.ts
ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/topStories.ts

Remove pageviewParams prop from AmpATIAnalytics tests.

src/app/components/ATIAnalytics/amp/index.test.tsx

Remove pageviewParams prop from CanonicalATIAnalytics.

src/app/components/ATIAnalytics/canonical/index.tsx
src/app/components/ATIAnalytics/types.ts

Remove redundant functions.

src/app/components/ATIAnalytics/atiUrl/index.ts
src/app/components/ATIAnalytics/beacon/index.ts
src/app/components/ATIAnalytics/canonical/getNoScriptTrackingPixelUrl/index.ts
src/app/components/ATIAnalytics/index.tsx
src/app/components/ATIAnalytics/params/buildParams/index.ts
src/app/components/ATIAnalytics/params/index.ts
src/app/contexts/EventTrackingContext/index.tsx
src/app/lib/analyticsUtils/staticATITracking/constructATIUrl/index.ts

Remove useReverb from event tracking hooks.

src/app/hooks/useClickTrackerHandler/index.jsx
src/app/hooks/useCustomEventTracker/index.tsx
src/app/hooks/useSwipeTracker/index.tsx
src/app/hooks/useViewTracker/index.tsx

Remove legacy usage of fetch function to make ATI/Piano requests.

src/app/lib/analyticsUtils/sendBeacon/index.ts

Add support for xtor tracking in the Lite site tracking code.

src/app/lib/analyticsUtils/staticATITracking/processClientDeviceAndSendStaticBeacon/index.ts

Remove useReverb from service config.

src/app/lib/config/services/<service_name>.ts

Remove useReverb from service config type definition.

src/app/models/types/serviceConfig.ts

Remove atiUrl from processClientDeviceAndSendStaticBeacon.
~~- Update snapshots to reflect the year 2026.~~
~~~ ~src/integration/pages/<page_type>/<service_name>/__snapshots__/<snapshot_name> ws-nextjs-app/integration/pages/<page_type>/<service_name>/__snapshots__/<snapshot_name>~ ~~~
Resolved via New year, new snapshots #13580
Remove the following utility functions from the src/app/lib/analyticsUtils/index.js module.

getScreenInfo
getBrowserViewPort
getCurrentTime
getDeviceLanguage
getAtUserId
getPublishedDatetime
getContentId
getAtiUrl
getEventInfo
getThingAttributes
getCampaignType
getRSSMarketingString
getAffiliateMarketingString
getSLMarketingString
getEmailMarketingString
getDisplayMarketingString
getCustomMarketingString
getXtorMarketingString
getATIMarketingString

Developer Checklist

Testing

Additional Testing Steps

Tracking Requests

Visit the sample pages below.
Check that page view event beacons are fired.
Check that component click and view event beacons are fired.

http://localhost:7080/arabic?renderer_env=live
http://localhost:7080/arabic/topics/cz9mm6r1q5et?renderer_env=live
http://localhost:7081/arabic/articles/cn5l501r46do?renderer_env=live
http://localhost:7081/arabic/articles/cn5l501r46do.lite?renderer_env=live
http://localhost:7081/arabic/articles/cn5l501r46do.amp?renderer_env=live

Data Persistence

Visit Piano and confirm that tracking data is accessible
via reports and data queries.

Useful Links

Coding Standards
Repository use guidelines
Add Links to useful resources related to this PR if applicable.

…anonicalATIAnalytics

…alATIAnalytics

cypress/e2e/specialFeatures/atiAnalytics/assertions/index.js

…ponentViewEvent

src/app/components/ATIAnalytics/beacon/index.ts

Isabella-Mitchell

Can we remove useReverb from https://github.com/bbc/simorgh/blob/WS-222-clean-up-CanonicalATIAnalytics/ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/index.ts#L186 (can see there were some recent changes here relating to homepage migration)

Isabella-Mitchell

Thanks for going over this on the call earlier. I think still have some way to go to understanding this work completely, but it makes sense as far as I can tell!

WS-222: Fix flaxy atuserid/idclient e2e tests

alex-magana · 2026-01-06T15:22:55Z

Can we remove useReverb from https://github.com/bbc/simorgh/blob/WS-222-clean-up-CanonicalATIAnalytics/ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/index.ts#L186 (can see there were some recent changes here relating to homepage migration)

This has been resolved via #13582. useReverb is now no longer
referenced in ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/index.ts.
Thanks for the feedback Izzy!

HarveyPeachey

Really great work on this Alex, just a couple of comments

HarveyPeachey · 2026-01-07T15:43:01Z

scripts/bundleSize/bundleSizeConfig.js

+export const MIN_SIZE = 924;
+export const MAX_SIZE = 1294;


HarveyPeachey · 2026-01-07T15:51:14Z

ws-nextjs-app/cypress/e2e/specialFeatures/atiAnalytics/assertions/billboard.ts


 export const assertBillboardComponentClick = ({
  pageIdentifier,
-  contentType,


Was this supposed to be removed from here?

alex-magana added 9 commits December 8, 2025 15:49

Delete buildATIPageTrackPath function

0611cfa

Remove buildATIPageTrackPath page view tracking unit tests

f896161

Delete buildATIPageTrackPath and buildPageATIUrl

1e5c7ab

Delete buildPageATIUrl unit tests

509ac33

Remove buildATIUrl and buildPageATIUrl functions

43b5533

Delete buildPageATIUrl integration test

e7ff184

Delete buildATIUrl unit tests

e5c089c

Delete buildATIUrl from the ATIAnalytics component

26e4b8f

Merge branch 'WS-222-clean-up-AmpATIAnalytics' into WS-222-clean-up-C…

5924a1d

…anonicalATIAnalytics

alex-magana changed the title ~~WS-222: [Canonical] - Delete dead/unused ATI code in Simorgh~~ WS-222: [CANONICAL] - Delete dead/unused ATI code in Simorgh Dec 9, 2025

alex-magana added 14 commits December 9, 2025 15:49

Remove useReverb flag from ATIAnalytics component

0f3c929

Remove url argument and 'fetch' invocation

d3cd486

Remove atiPageViewUrlString and atiPageViewUrl variables from Canonic…

af3dbd7

…alATIAnalytics

Remove baseUrl and pageviewParams from ATIAnalyticsProps

4c7abb9

Remove unused getEnvConfig

2c682d6

Remove redundant ATIAnalyticsPropsExport type

732b2b2

Change how reverbParams is passed to getNoScriptTrackingPixelUrl

7022927

Delete buildATIEventTrackUrl function

2592b4c

Remove atiClickTrackingUrl

bec83cd

Exclusively use Reverb in sendEventBeacon

d3d0532

Remove unused utilities imports

063faea

Delete buildATIEventTrackUrl unit tests

0534d0b

Remove unused mocks

7698846

Remove unused arguments

377c9fc

Base automatically changed from WS-222-clean-up-AmpATIAnalytics to latest December 11, 2025 09:25

alex-magana added 5 commits December 11, 2025 16:57

Delete splitUrl utility

b519c0f

Remove CPV tests

9842ea2

Update no-js tests

a5a9af7

Update CanonicalATIAnalytics unit tests

c4c13ed

Add xtor support for the Lite site to align with Canonical

fb410bf

alex-magana added 10 commits January 2, 2026 22:06

Delete unused getEmailMarketingString function

1082453

Delete unused getSLMarketingString function

f4d675c

Delete unused getAffiliateMarketingString function

88b6d0e

Delete unused getThingAttributes function

48eeba5

Delete unused getAtUserId function

b3aef2c

Delete unused getCurrentTime function

6ab22dd

Delete unused getPublishedDatetime function

de6f1f8

Merge branch 'latest' into WS-222-clean-up-CanonicalATIAnalytics

7b1384e

Remove analyticsUtils import

d24a3da

Remove redundant imports

d4cf896

alex-magana force-pushed the WS-222-clean-up-CanonicalATIAnalytics branch from 5779395 to d4cf896 Compare January 5, 2026 15:24

alex-magana added 4 commits January 5, 2026 18:38

Merge branch 'latest' into WS-222-clean-up-CanonicalATIAnalytics

cd1191e

Reinstate idclient assertion for the Next.js page view e2es

d8d83b7

Remove idclient value assertion

03b8ca0

Ensure idclient exists in viewability events request

d72d1d9

Isabella-Mitchell reviewed Jan 5, 2026

View reviewed changes

cypress/e2e/specialFeatures/atiAnalytics/assertions/index.js Show resolved Hide resolved

Pass applicationType in assertATIComponentClickEvent and assertATICom…

90f78f8

…ponentViewEvent

Isabella-Mitchell reviewed Jan 5, 2026

View reviewed changes

src/app/components/ATIAnalytics/beacon/index.ts Show resolved Hide resolved

Include applicationType in view and click tests where absent

91b918c

Isabella-Mitchell reviewed Jan 6, 2026

View reviewed changes

Isabella-Mitchell approved these changes Jan 6, 2026

View reviewed changes

Merge pull request #13582 from bbc/WS-222-clean-up-atuserid-assertions

e713831

WS-222: Fix flaxy atuserid/idclient e2e tests

alex-magana added 5 commits January 6, 2026 20:50

Merge branch 'latest' into WS-222-clean-up-CanonicalATIAnalytics

de1d360

Remove redundant useReverb flag

b55b8c2

Merge branch 'latest' into WS-222-clean-up-CanonicalATIAnalytics

ac30ec6

Merge branch 'latest' into WS-222-clean-up-CanonicalATIAnalytics

ca884d5

Update bundle upper threshold

2de829f

HarveyPeachey reviewed Jan 7, 2026

View reviewed changes

Merge branch 'latest' into WS-222-clean-up-CanonicalATIAnalytics

97a51da

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WS-222: [CANONICAL] - Delete dead/unused ATI code in Simorgh #13526

WS-222: [CANONICAL] - Delete dead/unused ATI code in Simorgh #13526

alex-magana commented Dec 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Isabella-Mitchell left a comment

Uh oh!

Isabella-Mitchell left a comment

Uh oh!

alex-magana commented Jan 6, 2026

Uh oh!

HarveyPeachey left a comment

Uh oh!

HarveyPeachey Jan 7, 2026

Uh oh!

HarveyPeachey Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

WS-222: [CANONICAL] - Delete dead/unused ATI code in Simorgh #13526

Are you sure you want to change the base?

WS-222: [CANONICAL] - Delete dead/unused ATI code in Simorgh #13526

Conversation

alex-magana commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Code changes

Developer Checklist

Testing

Additional Testing Steps

Tracking Requests

Data Persistence

Useful Links

Uh oh!

Uh oh!

Uh oh!

Isabella-Mitchell left a comment

Choose a reason for hiding this comment

Uh oh!

Isabella-Mitchell left a comment

Choose a reason for hiding this comment

Uh oh!

alex-magana commented Jan 6, 2026

Uh oh!

HarveyPeachey left a comment

Choose a reason for hiding this comment

Uh oh!

HarveyPeachey Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

HarveyPeachey Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alex-magana commented Dec 9, 2025 •

edited

Loading