-
Notifications
You must be signed in to change notification settings - Fork 262
Ws 1756 useful link dark UI 2 #13532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: latest
Are you sure you want to change the base?
Conversation
|
I think it would be a good idea to double-check with UX (Eva) whether this change should apply to all instances (both dark and light themes). AFAIK in the original Figma we didn't include the underline. This isn’t within the scope of your task, but maybe you could also update metadata.json with the a11y swarm link (which was done, but file not updated)? Thank you! |
dd3c5e3 to
f6732b1
Compare
Sure thing! I am contacting Eva about that. And metadata updated! |
Here is Eva's comment
|

Resolves JIRA: https://bbc.atlassian.net/browse/WS-1912
Summary
Adding underline for Useful links by default and a bit thicker underline for hover and focus:
