Rendu Ewen Horville#29
Open
The17thDoctor wants to merge 5 commits into
Open
Conversation
bcalou
reviewed
Nov 24, 2023
bcalou
left a comment
bcalou
left a comment
Owner
There was a problem hiding this comment.
Bien. Certains algos pourraient bénéficier d'un peu plus de commentaires pour comprendre la mécanique.
Comment on lines
+2
to
+5
| if number > 1: | ||
| return number * get_factorial(number - 1) | ||
| else: | ||
| return 1 |
Comment on lines
+11
to
+12
| if i == 0: | ||
| continue |
Owner
There was a problem hiding this comment.
On peut supprimer ça si on part directement du bon index ;)
| return merge(sort(array[:middle]), sort(array[middle:])) | ||
| else: | ||
| # For array of size 2, just swap if needed | ||
| return [array[1], array[0]] if array[1] < array[0] else array |
Owner
There was a problem hiding this comment.
Soit le comportement (simplifié) de la fonction merge pour ce cas précis. Il serait plus clair de rester sur la fonction merge plutôt que de répliquer ce comportement ici.
| return [array[1], array[0]] if array[1] < array[0] else array | ||
|
|
||
|
|
||
| def merge(array_1: list[int], array_2: list[int]): |
Owner
|
Code clair et bien structuré. Quelques petites améliorations possibles (mentionnées en code review), mais très bien. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.