Merged
Conversation
johan-bell
reviewed
Apr 8, 2026
Collaborator
johan-bell
left a comment
johan-bell
left a comment
There was a problem hiding this comment.
Tests failed locally,
ivanslabbert
approved these changes
Apr 9, 2026
Contributor
ivanslabbert
left a comment
ivanslabbert
left a comment
There was a problem hiding this comment.
Approved, but check comment from Johan - might be a flakey test?
The remaining low statement coverage on LPaginator (24%), ImageEditor (29%), MediaEditor (31%), UserOverview (28%), and EditContentBasic (41%) is primarily the v8 SFC <script setup> coverage artifact where the entire setup block counts as one uncovered function. Their branch and function coverage has improved significantly.
MrDirkelz
force-pushed
the
1463-cms-implement-full-test-coverage
branch
from
6d5ddb9 to
0876e9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining low statement coverage on LPaginator (24%), ImageEditor (29%), MediaEditor (31%), UserOverview (28%), and EditContentBasic (41%) is primarily the v8 SFC <script setup> coverage artifact where the entire setup block counts as one uncovered function. Their branch and function coverage has improved significantly.