ChainTableを利用した際に、次のテーブルに遷移する前に表のテキストを追加で表示できる機能の追加#610
Open
h-mikisato wants to merge 2 commits intobcdice:masterfrom
Open
ChainTableを利用した際に、次のテーブルに遷移する前に表のテキストを追加で表示できる機能の追加#610h-mikisato wants to merge 2 commits intobcdice:masterfrom
h-mikisato wants to merge 2 commits intobcdice:masterfrom
Conversation
他にも同様の独自テーブルを実装しているシステムはあったが、一番単純に書き換えできたため
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #610 +/- ##
==========================================
- Coverage 95.43% 95.43% -0.01%
==========================================
Files 332 333 +1
Lines 18589 18598 +9
Branches 4825 4830 +5
==========================================
+ Hits 17741 17749 +8
- Misses 848 849 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
これまではChainTableを特に工夫なく使った場合、
のような表示となり、表1固有のテキストを表示することができませんでした。
今回ChainWithTextというクラスを作成し、これをChainTableの項目とした場合に、
という表示を可能にしました。
同様のチェーン機能がD66Tableにも実装されていたため、こちらでも利用できるようにしてあります。
実用サンプルのために、独自のChainTableで実装されていた鋼鉄のユグドラシルの表をこの実装で書き換えました。