Add d/v options to Korean CoC7 Full Auto#802
Open
EATGamJaTang wants to merge 4 commits intobcdice:masterfrom
Open
Add d/v options to Korean CoC7 Full Auto#802EATGamJaTang wants to merge 4 commits intobcdice:masterfrom
EATGamJaTang wants to merge 4 commits intobcdice:masterfrom
Conversation
韓国語版『クトゥルフの呼び声 第7版』のフルオート判定に、日本語版で実装されている d(難易度)、v(ボレー)機能を追加 Add the d (difficulty) and v (volley) features implemented in the Japanese version to the Korean version of Call of Cthulhu 7th Edition Full Auto roll.
ysakasin
requested changes
Sep 5, 2025
Member
ysakasin
left a comment
There was a problem hiding this comment.
追加したコマンドのテストがありません。テストケースも翻訳して追加してください。
Conform to locale/dotted game_system IDs; add Full Auto d/v cases; update expected strings (“극단적 성공”, “100발”). 他言語・小数点付きの game_system ID に準拠、フルオートの d/v 追加、期待文言を調整(「극단적 성공」「100발」)。
Author
ご指摘ありがとうございます。以下を対応しました。
ご確認よろしくお願いします。 피드백 감사드립니다. 아래와 같이 반영했습니다.
확인 부탁드립니다. Thanks for the feedback. I’ve updated the PR as follows:
Kindly take another look. Thank you! |
ysakasin
requested changes
Feb 14, 2026
Member
ysakasin
left a comment
There was a problem hiding this comment.
寄稿ありがとうございます。連絡が遅れてすみません。
テストが失敗しているので、転機の間違いや翻訳の不統一がありそうです。GitHub Actionsで実行されたテストのエラーログを確認し、修正してください。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
變更內容
韓国語版 『クトゥルフの呼び声 第7版』フルオート判定に、
日本語版で実装されている d(難易度で中断)、v(ボレー弾数上限)機能を追加しました。
主なポイント
期待効果
日本語版と同等の機能を韓国語版でも利用可能にし、
ユーザーの混乱を減らし、多言語間のルールセット整合性を高めます。
변경 내용
한국어판 「크툴루의 부름 7판」 Full Auto 판정에
일본어판에서 구현되어 있던 d(난이도 중단), v(연발 탄수 상한) 기능을 추가했습니다.
주요 포인트
기대 효과
일본어판과 동일한 기능을 한국어판에서도 활용할 수 있어,
사용자 혼란을 줄이고 국제 룰셋 호환성을 확보합니다.
Changes
Added d (difficulty stop) and v (volley cap) options to the Korean version of Call of Cthulhu 7th Edition Full Auto roll, aligning with the Japanese implementation.
Key Points
Expected Impact
Provides feature parity with the Japanese version.
Reduces confusion for Korean users and improves cross-language ruleset consistency.