Merged
Conversation
Member
|
寄稿ありがとうございます。 BCDiceではセッション中に使うコマンドのみ受け付けています。命名表などがセッション中に使うものでなければ削除して欲しいのですが、各表を使うタイミングはどうなっていますか? |
Contributor
Author
|
ご確認いただきありがとうございます。 |
ysakasin
requested changes
Feb 21, 2026
| private | ||
|
|
||
| def roll_pd(command) | ||
| parser = Command::Parser.new(/\d*PD/, round_type: round_type) |
Member
There was a problem hiding this comment.
数値の部分は正規表現でなく、Command::Parser#enable_prefix_number を使用することでパースするようにしてください。
参考:
https://github.com/bcdice/BCDice/blob/master/lib/bcdice/game_system/DemonSpike.rb#L32-L43
Contributor
Author
|
確認ありがとうございます。 |
ysakasin
approved these changes
Feb 21, 2026
Member
|
寄稿ありがとうございます。マージしました |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F.E.A.R.の新作であるプレシャスデイズのダイスボットを実装しました。
以上、お手すきの際にご確認お願いします。