#4539 - Add Duplicate SIN Validation

[tiago-graf]

Summary

Adds a duplicate validation when manually adding a SIN number to a student in the Ministry Portal.

Frontend

Updates the AddNewSIN modal component to include new banner and confirmation checkbox.
Updates the SINManagement view to move the save SIN method to the AddNewSIN component (to allow resubmission without closing the modal)

Backend

Updates the create SIN model to include optional confirmDuplicate property.
Updates the SIN validation service to include new duplicate validation.
Updates the student controller to handle the custom error (duplicate not confirmed).

E2E

Adds new tests for the different validation scenarios.

[Copilot]

Pull request overview

This PR implements a duplicate SIN validation check when Ministry users manually add a SIN to a student profile. If a duplicate is detected, the user is warned and must explicitly confirm before proceeding.

Changes:

• Adds optional confirmDuplicateSIN field to the CreateSINValidation DTO (frontend and backend)
• Implements duplicate SIN check in the SINValidationService and controller
• Updates the AddNewSIN modal to display a warning banner and confirmation checkbox when duplicates are detected, and moves the save logic into the modal component to allow resubmission
• Adds comprehensive e2e tests covering duplicate rejection, duplicate confirmation, and unique SIN scenarios

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
sources/packages/web/src/views/aest/student/SINManagement.vue	Moves SIN creation logic to modal component; simplifies parent component's responsibilities
sources/packages/web/src/services/http/dto/Student.dto.ts	Adds optional confirmDuplicateSIN field to CreateSINValidationAPIInDTO
sources/packages/web/src/constants/error-code.constants.ts	Defines SIN_DUPLICATE_NOT_CONFIRMED error constant
sources/packages/web/src/components/common/sin/AddNewSIN.vue	Adds duplicate warning UI, confirmation checkbox, and inline SIN creation logic with error handling
sources/packages/backend/apps/api/src/services/sin-validation/sin-validation.service.ts	Implements checkDuplicateSIN method to detect existing SINs across student profiles
sources/packages/backend/apps/api/src/route-controllers/student/student.aest.controller.ts	Adds duplicate SIN validation and throws UnprocessableEntityException when not confirmed
sources/packages/backend/apps/api/src/route-controllers/student/models/student.dto.ts	Adds optional confirmDuplicateSIN boolean field with validation decorators
sources/packages/backend/apps/api/src/route-controllers/student/tests/e2e/student.aest.controller.createStudentSINValidation.e2e-spec.ts	Adds e2e tests for duplicate rejection, duplicate confirmation, and unique SIN scenarios
sources/packages/backend/apps/api/src/constants/error-code.constants.ts	Defines SIN_DUPLICATE_NOT_CONFIRMED constant for backend error handling

[weskubo-cgi]

Changes look great. Just some minor questions/comments to resolve.

[weskubo-cgi]

thought: There's a lot going on in this screen now. Should we do quick review with the business?

[tiago-graf]

yeah, i believe it even makes the modal screen scroll a bit when all the banners are displayed

[weskubo-cgi]

question: Is there any reason to use this instead of const addNewSINModal = ref({} as ModalDialog<boolean>);

[tiago-graf]

Not a particular reason, it only changed because the modal wont return the Model anymore, and i like the InstaceType better.

[dheepak-aot]

As all the modals follow a common design system with type ModalDialog. I would stick to common interface. The modified approach is better if a component has it's own unique properties which requires to be typed.

[dheepak-aot]

using exists would simplify this.

const exists = await this.dataSource.getRepository(Student).exists({
      where: {
        id: Not(studentId),
        sinValidation: {
          sin: normalizedSIN,
        },
      },
    });

[dheepak-aot]

Sorry for not being clear. returning the exists would be good.

return this.dataSource.getRepository(Student).exists({
      where: {
        id: Not(studentId),
        sinValidation: {
          sin: normalizedSIN,
        },
      },
    });

[dheepak-aot]

Please share the title with business as it wasn't in the AC.

[dheepak-aot]

Minor. The AC has Add SIN now enclosed in double quotes.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	20.15% ( 4322 / 21444 )
Methods:	9.67% ( 253 / 2616 )
Lines:	24.32% ( 3711 / 15258 )
Branches:	10.03% ( 358 / 3570 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	75.41% ( 1055 / 1399 )
Methods:	79.31% ( 115 / 145 )
Lines:	78.79% ( 769 / 976 )
Branches:	61.51% ( 171 / 278 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	85.68% ( 1616 / 1886 )
Methods:	85% ( 187 / 220 )
Lines:	88.64% ( 1287 / 1452 )
Branches:	66.36% ( 142 / 214 )

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	77.52% ( 8903 / 11485 )
Methods:	77% ( 1051 / 1365 )
Lines:	81.59% ( 6460 / 7918 )
Branches:	63.22% ( 1392 / 2202 )

[dheepak-aot]

Please add a period to the message.

[dheepak-aot]

Is the value required to be reset??

[dheepak-aot]

The error can be thrown inside the if block as it does not have reason to live outside.

if (!payload.confirmDuplicateSIN) {
      // Check for duplicate SIN if confirmation is not provided.
      const isDuplicate = await this.sinValidationService.checkDuplicateSIN(
        studentId,
        payload.sin,
      );
      if (isDuplicate) {
        throw new UnprocessableEntityException(
          new ApiProcessError(
            "This SIN is currently associated with another student profile and confirmation to allow duplication SIN is missing.",
            SIN_DUPLICATE_NOT_CONFIRMED,
          ),
        );
      }
    }