feat: updated conditions filter logic to accurately filter results#1037
Open
JazzarKarim wants to merge 6 commits intobcgov:mainfrom
Open
feat: updated conditions filter logic to accurately filter results#1037JazzarKarim wants to merge 6 commits intobcgov:mainfrom
JazzarKarim wants to merge 6 commits intobcgov:mainfrom
Conversation
|
thorwolpert
approved these changes
Feb 12, 2026
Collaborator
thorwolpert
left a comment
thorwolpert
left a comment
There was a problem hiding this comment.
nice, and decent changes on the tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
I tested my changes in the registrations table as well, they work.
I also compared results with what we already had in DEV, the numbers check out:
When I select PR in DEV, I get 543 results.
In here with my new changes:
274 + 269 = 543 which makes sense. Just some fun math here to verify results 😁
Did some refactoring to the code to fix the Cognitive Complexity issue reported by SC:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License