31865 - Update Resolution Date Validation in Share Structures

[meawong]

Issue #: /bcgov/entity#31865

Description of changes:

Multiple resolution dates:

Resolution date in the future:

Resolution date before business founding date:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[loneil]

Makes sense to me. I'm not to knowledgeable on the update parts in the filer but just code-wise appears good. Tagged copilot just for fun too

[Copilot]

Pull request overview

Updates share structure resolution-date validation rules (primarily in legal-api) and aligns business-filer correction behavior/tests with preserving historical resolution dates.

Changes:

• Added/expanded resolution date validation in share structures (required when rights/restrictions exist, single date only, not future-dated, not before founding date).
• Wired the new validation into Alteration and Correction (corps) filing validation flows and added/updated unit tests for these scenarios.
• Adjusted business-filer correction processing/tests to preserve historical resolution dates; updated registry_schemas dependency version.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
queue_services/business-filer/tests/unit/test_filer/test_correction_bcia.py	Updates expectations around correction behavior for resolution dates (history preservation).
queue_services/business-filer/src/business_filer/filing_processors/filing_components/shares.py	Refactors resolution-date updating and reuses it for corrections.
legal-api/tests/unit/services/filings/validations/test_correction_ia.py	Adds deterministic tests for correction resolution-date validation rules.
legal-api/tests/unit/services/filings/validations/test_alteration.py	Extends alteration tests to cover new resolution-date validation rules.
legal-api/src/legal_api/services/filings/validations/correction.py	Passes business into corp correction validation and invokes share-structure resolution-date validation.
legal-api/src/legal_api/services/filings/validations/common_validations.py	Implements expanded resolution-date validation rules (count/date bounds) with business founding-date comparison.
legal-api/src/legal_api/services/filings/validations/alteration.py	Updates call site for the new validation signature and aggregates multiple errors.
legal-api/pyproject.toml	Bumps registry_schemas git ref.
legal-api/poetry.lock	Locks updated registry_schemas version/reference.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[vysakh-menon-aot]

can you update the filer version https://github.com/bcgov/lear/blob/main/queue_services/business-filer/pyproject.toml#L3