32075 Legal-API: Validation on director names for CoD #4076
+139
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas <lucasoneil@gmail.com>
loneil
force-pushed
the
32075changeDirectorNameValidation
branch
from
2353680 to
4a7f6a3
Compare
loneil
commented
Feb 13, 2026
|
|
||
| return msg | ||
|
|
||
| def validate_directors_name(cod: dict) -> list: |
Collaborator
Author
There was a problem hiding this comment.
There is a validate_party_name function in common validations, but this one has differences than a party name (though posted as basically the same format from the UI) in that there's the prev* fields, the role isn't variable, and there's the actions to take into account.
Could maybe generalize a "validate person name" that is shared but there's also the 20 character limit on the name fields, so probably consider any refactoring in context with https://app.zenhub.com/workspaces/entities-team-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/31979 if that gets addressed at some point.
loneil
requested review from
Rajandeep98,
argush3,
meawong and
vysakh-menon-aot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#32075
Description of changes:
There isn't any validation API side on director field format (other than schema) so blank fields and invalid lengths and whitespacing is passing. Add name validation for director officer in the CoD validator.
Note: this will validate required director name for all cases, even if it's an
addressChangedaction, which matches the FE behavior where it sends the director name anyways.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).