Skip to content

SFMS: Monday FWI interpolations#5106

Open
conbrad wants to merge 3 commits intomainfrom
task/sfms-monday-interpolation
Open

SFMS: Monday FWI interpolations#5106
conbrad wants to merge 3 commits intomainfrom
task/sfms-monday-interpolation

Conversation

@conbrad
Copy link
Collaborator

@conbrad conbrad commented Feb 5, 2026

  • On Mondays, the sfms_daily_actuals job now also interpolates FFMC, DMC, and DC from WF1 station actuals (in addition to the existing temp/precip interpolation), storing rasters at the
    standard sfms/interpolated/ path
  • Extract FWI codes (fineFuelMoistureCode, duffMoistureCode, droughtCode) from WF1 dailies into SFMSDailyActual
  • Add StationFFMCSource, StationDMCSource, StationDCSource for simple IDW interpolation
  • Rename PrecipitationInterpolationProcessorIDWInterpolationProcessor to reflect its generic usage

Closes #5102

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.13%. Comparing base (2fb7676) to head (3bed24f).

Files with missing lines Patch % Lines
...packages/wps-shared/src/wps_shared/schemas/sfms.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5106      +/-   ##
==========================================
- Coverage   75.17%   75.13%   -0.05%     
==========================================
  Files         592      592              
  Lines       28706    28744      +38     
  Branches     2106     2108       +2     
==========================================
+ Hits        21579    21596      +17     
- Misses       6487     6511      +24     
+ Partials      640      637       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@conbrad conbrad requested review from brettedw and dgboss February 5, 2026 19:56
…tuals.py

Co-authored-by: dgboss <darren.boss@gov.bc.ca>
@conbrad conbrad requested a review from dgboss February 5, 2026 22:53
)


class StationFFMCSource(StationInterpolationSource):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about de-duping the precip, ffmc, dc and dmc sources?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, maybe just FWISource?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense if de-dedping just ffmc, dc and dmc but if throwing in precip maybe IDWSource?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opted for StationActualSource since they're just raw actuals and everything gets IDW'd: 3bed24f

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@conbrad conbrad requested a review from dgboss February 6, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SFMS Insights: Monday FWI Reinterpolation

2 participants