Including atmosphere, qe, reflectivity in VISTA filters#42
Merged
Conversation
Owner
|
I think this looks good, and the comments seem clear about what was done. The QE is probably not totally zero outside the range, but it does look to be dropping rapidly enough that this is a reasonable choice to make. I can update the filters/README.md file when this is merged. |
Owner
|
Thanks @stevet40 !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40 (but at what cost?)
This is a much bigger change than #39, so it would probably be good for someone to independently verify what I've done here.
I have downloaded the data from the ESO webpage, and used it to construct combined transmission curves for VISTA/VIRCAM. These include the Paranal model atmosphere (PWV=1mm, airmass=1), the quantum efficiency, and the mirror reflectivity for M1 and M2. The combined curves I'm proposing are shown below, compared to what we have previously (which was filter only).
My proposed change here is to promote these new curves to the names
vista_vircam_*.par, and to retain what we had previously as something likevista_vircam_*_FILTER.par. I've tried to improve the comments in the various files, so it's hopefully unambiguous what I did in each case.Two things where I made a decision (that others may disagree with):
Let me know what you think!