Resolving docker build warnings during CD#340
Merged
Conversation
- Fix legacy ENV format for BUILD_DEPENDENCIES (line 13) - Add ARG VERSION to run stage to fix undefined variable warning - Apply fixes to all php-lol variants (8.1, 8.2, 8.3, 8.4)
Copilot created this pull request from a session on behalf of
bdossantos
June 4, 2026 10:15
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce Docker build-time warnings during CD for the php-lol image variants by adjusting Dockerfile variable declarations so BuildKit/Hadolint-style linters are less likely to flag legacy ENV formatting and undefined variables.
Changes:
- Rewrites
ENV BUILD_DEPENDENCIESintokey="value"format (instead of legacykey value) across PHP 8.1–8.4 Dockerfiles. - Adds
ARG VERSION=<x.y.z>in the finalrunstage so$VERSIONis explicitly defined in that stage beforeLABELexpansion.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| dockerfiles/php-lol/Dockerfile.8.4 | Converts BUILD_DEPENDENCIES ENV to key=value format; adds ARG VERSION for label expansion in final stage. |
| dockerfiles/php-lol/Dockerfile.8.3 | Same as 8.4: ENV formatting change + ARG VERSION in run stage. |
| dockerfiles/php-lol/Dockerfile.8.2 | Same as 8.4: ENV formatting change + ARG VERSION in run stage. |
| dockerfiles/php-lol/Dockerfile.8.1 | Same as 8.4: ENV formatting change + ARG VERSION in run stage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
227
to
230
| ARG BUILD_DATE | ||
| ARG VCS_REF | ||
| ARG VERSION=8.4.21 | ||
|
|
Comment on lines
229
to
232
| ARG BUILD_DATE | ||
| ARG VCS_REF | ||
| ARG VERSION=8.3.31 | ||
|
|
Comment on lines
229
to
232
| ARG BUILD_DATE | ||
| ARG VCS_REF | ||
| ARG VERSION=8.2.31 | ||
|
|
Comment on lines
229
to
232
| ARG BUILD_DATE | ||
| ARG VCS_REF | ||
| ARG VERSION=8.1.34 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent