Skip to content

Test CI against multiple OTP versions (24-28) #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Oct 19, 2025
Merged

Test CI against multiple OTP versions (24-28) #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 48 additions & 35 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,43 +10,56 @@ on:

jobs:
build:
name: Test on OTP ${{ matrix.otp_version }} and ${{ matrix.os }}
name: OTP ${{ matrix.otp_version }} / rebar3 ${{ matrix.rebar3_version }} / ${{ matrix.os }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
otp_version: ["26.1.2", "25.2", "24.3.4.7"]
os: [ubuntu-22.04]
rebar3_version: ["3.22.1"]
include:
- otp_version: "23.3.4.18"
os: ubuntu-20.04
rebar3_version: "3.20.0"
- otp_version: "22.3.4.26"
os: ubuntu-20.04
rebar3_version: "3.18.0"
Comment on lines -22 to -27
Copy link
Contributor Author

@kianmeng kianmeng Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped support for OTP 22/23 as the minimum supported Ubuntu OS image not supported by setup-beam anymore, see https://github.com/erlef/setup-beam?tab=readme-ov-file#compatibility-between-operating-system-and-erlangotp

env:
OTP_VERSION: ${{ matrix.otp_version }}
- otp_version: "24"
rebar3_version: "3.21.0"
os: ubuntu-latest
- otp_version: "25"
rebar3_version: "3.21.0"
os: ubuntu-latest
- otp_version: "26"
rebar3_version: "3.25.1"
os: ubuntu-latest
- otp_version: "27"
rebar3_version: "3.25.1"
os: ubuntu-latest
- otp_version: "28"
rebar3_version: "3.25.1"
os: ubuntu-latest

steps:
- uses: actions/checkout@v4
- uses: erlef/setup-beam@v1
with:
otp-version: ${{ matrix.otp_version }}
rebar3-version: ${{ matrix.rebar3_version }}
version-type: loose
- uses: actions/cache@v3
name: Cache
with:
path: |
_build
key: ${{ runner.os }}-build-${{ matrix.otp_version }}-${{ hashFiles(format('rebar.lock')) }}-1
restore-keys: |
${{ runner.os }}-build-${{ matrix.otp_version }}-1-
- name: Compile
run: rebar3 compile
- name: Common Test tests
run: rebar3 ct --cover
- name: XRef
run: rebar3 xref
- name: Dialyzer
run: rebar3 dialyzer
- uses: actions/checkout@v5

- uses: erlef/setup-beam@v1
with:
otp-version: ${{ matrix.otp_version }}
rebar3-version: ${{ matrix.rebar3_version }}

- uses: actions/cache@v4
name: Cache
with:
path: |
_build
key: ${{ runner.os }}-build-${{ matrix.otp_version }}-${{ matrix.rebar3_version }}-${{ hashFiles(format('rebar.lock')) }}-1
restore-keys: |
${{ runner.os }}-build-${{ matrix.otp_version }}-${{ matrix.rebar3_version }}-1-

- name: Report
run: rebar3 report "compile"

- name: Compile
run: rebar3 compile

- name: Common Test tests
run: rebar3 ct --cover

- name: XRef
run: rebar3 xref

- name: Dialyzer
run: rebar3 dialyzer
if: ${{ matrix.otp_version == 28 }}
2 changes: 1 addition & 1 deletion test/telemetry_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ invoke_exception_span_handlers(Config) ->
ExceptionEvent = EventPrefix ++ [exception],
HandlerConfig = #{send_to => self()},
StartMetadata = #{some => start_metadata, telemetry_span_context => ctx},
SpanFunction = fun() -> 1 / 0 end,
SpanFunction = fun() -> erlang:error(badarith) end,
Copy link
Contributor Author

@kianmeng kianmeng Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

===> Compiling telemetry
     ┌─ test/telemetry_SUITE.erl:
     │
 388 │      SpanFunction = fun() -> 1 / 0 end,
     │                                ╰── Warning: evaluation of operator '/'/2 will fail with a 'badarith' exception


===> Running Common Test suites...


telemetry:attach_many(HandlerId, [StartEvent, ExceptionEvent], fun ?MODULE:echo_event/4, HandlerConfig),

Expand Down