fix item_rewards.py#19
Conversation
…ities This commit updates the `item_rewards.py` file to address two issues: 1. It skips processing for items named "Empty". 2. It ensures that items not present in `chest_item_tiers` are handled by adding them with a default quality level.
|
See https://discord.com/channels/731205301247803413/1022545979146252288/1520022989914112130 and surrounding comments for context. |
| if item_name == "Empty": | ||
| continue |
There was a problem hiding this comment.
If "Empty" is in an event location, doesn't that still need a dialog?
The game displays a dialog when you do the event, doesn't it?
There was a problem hiding this comment.
It looks to me like we still want to process the "Empty"s.
The only problem was "Empty" not being in the qualities
There was a problem hiding this comment.
Yeah, agreed - fixed in next commit
|
Thank you for investigating and developing a fix for this bug. It seems like some of these changes have the goal of avoiding crashes. I think the goal of avoiding bugs is more important than avoiding crashes. And avoiding crashes is actually counter-productive - it makes bugs more likely. For example: if "Cursed Shld" in Rom.item_name_id:
qualities[Rom.item_name_id["Cursed Shld"]] = 1
Also, when making a change with a pull request, the normal practice is to use a different branch for each pull request. (And often, the branch is deleted after the pull request is merged.) It makes it a little more difficult for me when you use the same branch for multiple different pull requests. I've made a new PR from a new branch with how I would address this problem. |
2 participants
Skip "Empty" items and handle missing item qualities
This commit updates the
item_rewards.pyfile to address two issues:chest_item_tiersare handled by adding them with a default quality level.