get validation to work for bootstrap 4

[rakelkar]

set d-block to get the invalid feedback to show up as red
set is-invalid on the form control for a lovely red border

[beenje]

Thanks for the PR!
Where did you get the d-block from? I don't see it anywhere in the official documentation (for forms): https://getbootstrap.com/docs/4.1/components/forms/

[rakelkar]

The Great God of stack overflow or I looked at the source, don't remember :)

…

On Sun, Jun 3, 2018, 10:49 PM Benjamin Bertrand ***@***.***> wrote: Thanks for the PR! Where did you get the d-block from? I don't see it anywhere in the official documentation (for forms): https://getbootstrap.com/docs/4.1/components/forms/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADQphSKEEo4qbpCiycmjqvW8fA3ejCc0ks5t5Bq0gaJpZM4UQCh0> .

[rakelkar]

d-block is display block... Bootstrap says: Since Bootstrap applies display: block and width: 100% to almost all our form controls... https://getbootstrap.com/docs/4.0/components/forms/ But quick-form was not applying it... Can't find the post that led me to this though...

…

On Sun, Jun 3, 2018, 11:24 PM Rakesh Kelkar ***@***.***> wrote: The Great God of stack overflow or I looked at the source, don't remember :) On Sun, Jun 3, 2018, 10:49 PM Benjamin Bertrand ***@***.***> wrote: > Thanks for the PR! > Where did you get the d-block from? I don't see it anywhere in the > official documentation (for forms): > https://getbootstrap.com/docs/4.1/components/forms/ > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#1 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ADQphSKEEo4qbpCiycmjqvW8fA3ejCc0ks5t5Bq0gaJpZM4UQCh0> > . >

[beenje]

Sorry for the delay.
I must say I don't really use the quick_form macro. The code got quite messy and doesn't really work for me.
There is a PR that re-wrote support for wtf with bootstrap4 that might be interesting to look at: mbr#167

I'll merge this anyway as it solves some issues.