[16.0][FIX] shift : hide parent name in kanban view#596
Conversation
|
The field worker_name isn't used anywhere else than in the kanban view. I'm assuming the field has been created solely in the purpose to fill the kanban list. So changing display_name to name shouldn't have any non-desirable effect anywhere else. |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 60f212a. Thanks a lot for contributing to beescoop. ❤️ |
huguesdk
changed the title
| # name rather than display_name, so the parent doesn't appear | ||
| # on worker list in kanban | ||
| rec.worker_name = ",".join(rec.worker_ids.mapped("name")) |
There was a problem hiding this comment.
it’s good to have a comment, but as this explains the change and not the why this line is here, it’s better to put it in the commit message (next time). feel free to give as much explanation as relevant in the commit message. it’s even better there than in the pull request, as it’s easier to find back when inspecting the code.
3 participants
Description
Replace display_name by name for workers list, so that in kanban view parent partner doesn't appear in the list.
Odoo task (if applicable)
16701
Checklist before approval