Require typing_extensions on Python < 3.13#193
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
|
Sorry for the delay! Could you elaborate on the reasoning behind working around installing From experience, version checks like the ones introduced in this PR tend to become brittle and harder to maintain over time. The My preference would be to add |
|
So, two things:
I could just add it, but it wouldn't be needed on newer releases, so I changed the imports to be more future-focussed. As soon as you drop support for 3.13, you can drop the dependency (and simplify the imports). If you just want a dependency on In Debian, we'll probably continue to carry the patch to use typing, because we don't need to support the older releases. |
|
If it’s beneficial on your side, I don’t mind the version gated dependency too much here. From beets perspective, we already depend on |
On newer Python releases, the typing module has all we need. Fixes: beetbox#189
08f8e3b to
4f93c1e
Compare
On newer Python releases, the typing module has all we need.
Fixes: #189