Skip to content

Fix selected test subprocess buffering#103

Closed
puneetdixit200 wants to merge 3 commits into
beeware:mainfrom
puneetdixit200:codex/fix-selected-buffering
Closed

Fix selected test subprocess buffering#103
puneetdixit200 wants to merge 3 commits into
beeware:mainfrom
puneetdixit200:codex/fix-selected-buffering

Conversation

@puneetdixit200

@puneetdixit200 puneetdixit200 commented May 20, 2026

Copy link
Copy Markdown

Summary

  • Force Cricket's async test executor subprocess pipes to use unbuffered binary mode.
  • Add a regression test that verifies selected test execution passes bufsize=0 when creating the backend subprocess.
  • Repair the GitHub Actions workflow by moving off unavailable Python/action versions, using Toga's dummy backend for tests, pinning compatible Django/pytest/Toga test dependencies, and running unittest discovery directly.

Closes #91.

Verification

  • env/bin/python -m unittest tests.test_executor.ExecutorTests.test_subprocess_uses_unbuffered_binary_pipes
  • env/bin/python -m unittest tests.test_executor tests.test_unittest tests.test_models
  • PATH=$PWD/env/bin:$PATH TOGA_BACKEND=toga_dummy env/bin/python -m unittest tests.test_pytest
  • Selected-folder smoke test using UnittestTestSuite.find_tests(labels={'tests.submodule'}) and Executor.run()
  • env/bin/python -m py_compile setup.py cricket/executor.py tests/test_executor.py
  • git diff --check

AI-assisted work

This change was prepared with AI assistance and manually reviewed.

@freakboy3742

Copy link
Copy Markdown
Member

Closing as part of a flood of AI generated content from the same user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subprocess Runtime warning: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used

2 participants