WinForms and Android refactor for Container#4484
Conversation
Winforms refactor
|
@johnzhou721 Please merge Tag me when you've done so. Thank you. |
|
@kattni I've merged with main; thanks. |
phildini
left a comment
There was a problem hiding this comment.
This seems reasonable; is it truly the case that no tests are needed here?
First off, thank you for taking the time to review this pull request and suggest the addition of new tests. I believe that there should not be a need for additional tests, as these are merely changes in the internal structure of how Window is handled, rather than new behaviors; existing behaviors related to Container would all be covered in existing tests. If there is anything else you would like to see tested, please let me know so I can add them. |
kattni
left a comment
There was a problem hiding this comment.
Thank you for following up. One minor change applied.
|
|
|
The setuptools_scm issues turned into a bigger problem; see #4498 for the updates required. |
|
@johnzhou721 I've merged |
Container and Windowss on Winforms and Android now uses a "has-a" relationship instead of a "is-a" relationship. This will simplify scaffold implementation later, as there's an additioanl layer that manages containers.
Refs #4382.
PR Checklist:
Assisted-by: