Write all log messages to stderr#1852
Open
jennings wants to merge 2 commits into
Open
Conversation
Diagnostic output is usually expected to go to standard error, leaving standard output for program output (which is the formatted file when using `--write-stdout` or reading from stdin). Changes ConsoleLogger to write all log messages to stderr, and updates all tests to match.
Contributor
Author
|
It occurs to me that me that many people expect well-behaved daemons to log to stdout. Perhaps logs should go to stderr when running as a program but to stdout when running as a server? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Diagnostic output is often expected to go to standard error, leaving standard output for program output (which is the formatted file when using
--write-stdoutor reading from stdin).Changes ConsoleLogger to write all log messages to stderr, and updates all tests to match.
Related Issue
Related to #1851, but isn't the complete fix (that issue needs the exit code changed)
Checklist
varthis.