-
Notifications
You must be signed in to change notification settings - Fork 7
Update pre-commit config file #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Jeff Garland <jeff@crystalclearsoftware.com>
| CXX_MODULES_BMI | ||
| DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/beman.scope/bmi-${CMAKE_CXX_COMPILER_ID}_$<CONFIG> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. We don't have a standard for how to do this, but this seems reasonable for now -- but something we need to ultimately add into exemplar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this -- I've recorded an issue for us to look at bemanproject/exemplar#272 (comment)
|
ok so what's with this part of the install given that the library is header only? Is this something that's a side effect of the module packaging? -- Installing: /Users/clausklein/.local/lib/libbeman.scope.a Outside of this, I'm happy with the PR. |
Yes, see the |
JeffGarland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving and merging. @ClausKlein thanks for the refinements
Feature: add example/scope-module if possible too: