Split Benchee integration tests#483
Closed
Will-thom wants to merge 1 commit into
Closed
Conversation
d033bb5 to
8b4e8e8
Compare
Contributor
Author
|
Rebased this branch onto the current main and resolved the test split conflict by moving the newer max_sample_size default integration coverage into the dedicated max_sample_size test module. Local validation ran in an ephemeral Elixir 1.17 Docker container: mix test test/benchee/max_sample_size_test.exs test/benchee_test.exs Result: 33 tests, 0 failures, 2 excluded. |
Member
Merged
Member
|
Merged as #487 - thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #480
Validation
The validation was run in an isolated Docker container with Elixir 1.17.3 / OTP 27.