Fix(Workflow): Bring windows build back to life #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JingrenWang <wjrforcyber@163.com>
Contributor
|
Thank you for the great PR! We are investigating it and hope to merge soon. |
Contributor
|
Hi wjrforcyber. I would like to thank you again for this great fix. Now the Windows version can be used! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This windows build has been crashed for some time.
I spent some time fixing this with the help of glm 4.7, there are still some warning, but at least it can successfully build now.
Some commits directly use POSIX functions or C++17 standard since windows build crash, which are quite tricky to work with VS environment... 🫠