Fix CI to pass again and remove obsolete typing stub pytest_httpserver.pyi for fixing mypy #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CI issues by adjusting test coverage thresholds and removing an obsolete typing stub file for pytest_httpserver to resolve mypy conflicts.
- Lowered test coverage threshold from 96% to 95% to prevent CI failures
- Removed exclusion of
xcp/dmv.pyfrom diff-cover analysis - Deleted obsolete typing stub file
pytest_httpserver.pyito fix mypy issues
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tox.ini | Adjusted test coverage threshold and removed file exclusion from diff-cover |
| stubs/pytest_httpserver.pyi | Completely removed obsolete typing stub file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Pull Request Test Coverage Report for Build 17938458370Details
💛 - Coveralls |
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
bernhardkaindl
force-pushed
the
mypy-Remove-obsolete-typing-stub-pytest_httpserver
branch
from
f43eb6d to
18a1741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CI to pass again and remove obsolete typing stub pytest_httpserver.pyi for fixing mypy